[full-ci] Fix several file handling issues for apps #6456
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
fix_mediaviewer
branch
from
6c36514
to
bcc949c
Compare
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23237/66/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIUpload-upload_feature-L94.png |
dschmidt
changed the title
dschmidt
force-pushed
the
fix_mediaviewer
branch
from
5db751c
to
4f1cc8e
Compare
|
Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/23243/57/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUILogin-openidLogin_feature-L22.pngwebUILogin-openidLogin_feature-L29.png |
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23243/66/1
|
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23243/67/1
|
| @@ -0,0 +1,6 @@ | |||
| Bugfix: File handling in apps | |||
|
|
|||
| We fixed loading and saving files in apps in all contexts. It's now to open files in apps in personal files, favorites, share views and spaces. | |||
There was a problem hiding this comment.
| We fixed loading and saving files in apps in all contexts. It's now to open files in apps in personal files, favorites, share views and spaces. | |
| We fixed loading and saving files in apps in all contexts. It's now possible to open files in apps in personal files, favorites, share views and spaces. |
|
|
||
| We fixed loading and saving files in apps in all contexts. It's now to open files in apps in personal files, favorites, share views and spaces. | ||
|
|
||
| https://github.com/owncloud/web/pull/6456/files |
There was a problem hiding this comment.
| https://github.com/owncloud/web/pull/6456/files | |
| https://github.com/owncloud/web/pull/6456 |
dschmidt
force-pushed
the
fix_mediaviewer
branch
from
4f1cc8e
to
ff729a5
Compare
|
SonarCloud Quality Gate failed. |
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23267/67/1
|
Description
This PR fixes a bunch of scenarios where mediaviewer (and possibly other apps) were broken:
getUrlForResourcewas using an ugly hack to retrieve a webdav url beforewebDavPathwas introduced in Add space front page & bump SDK tov2.0.0#6287, we could now get rid of that hack and make this function work for spaces and a bunch of other contexts work as well (Kudos for that PR!!)pathinstead of thewebDavPath: that broke reloadingqs.parseinvocation was missing theallowDotsoption, so nested objects in query were not correctly parsed and closing the apps, at least on public links was brokenRelated Issues
There are two oCIS bugs left, which cause the mediaviewer to fail
With oC 10 everything seems to work just fine.
Biggest remaining issue is, that reloading the mediaviewer will only load the correct context folder for personal files or public links - i.e. if you open the mediaviewer in the shares overview you can cycle through your shared pictures, if you reload the page you will cycle through the folder from which the file was shared.
Fixing that is way beyond the scope of this PR and needs to be handled in a follow up PR.
Motivation and Context
It's annoying when the mediaviewer or other apps don't work in all contexts :-P
How Has This Been Tested?
Apart from the before mentioned issues, I'm not aware of any remaining ones.
With these changes the mediaviewer works in
Personal,Favorites,Shared With Others,Shared Via LinkandSpacesviews.JustShared With MeI haven't tested yet.Shared With Mewas tested, works.Query Parsing seems to behave a little weird, needs to be double checked again.I needed the change to fix closing apps on public links, but now reloading seems broken inPersonal. Marking the PR as WIP for now.Seems to have been a hiccup, cannot reproduce anymore.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: