Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space quota #6477

Merged
merged 8 commits into from
Mar 5, 2022
Merged

Space quota #6477

merged 8 commits into from
Mar 5, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 24, 2022 •
edited
Loading

Description

Enhancement: Allow updating space quota

We have implemented a way to update the space's quota

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear changed the base branch from master to space-special-items-enhanchement February 25, 2022 11:18
@AlexAndBear AlexAndBear force-pushed the space-special-items-enhanchement branch from 638b64a to db8d348 Compare February 28, 2022 08:19
@delete-merged-branch delete-merged-branch bot deleted the branch master March 1, 2022 10:17
@AlexAndBear AlexAndBear changed the base branch from space-special-items-enhanchement to master March 1, 2022 10:18
@AlexAndBear AlexAndBear force-pushed the space-quota branch 3 times, most recently from c862a96 to b8b2ece Compare March 1, 2022 14:55
@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23154/66/1
The following scenarios passed on retry:

  • webUIUpload/uploadEdgecases.feature:109

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23154/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:62

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23164/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:46

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23164/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/23164/72/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-uploadFileGreaterThanQuotaSize_feature-L12.png

webUIUpload-uploadFileGreaterThanQuotaSize_feature-L12.png

webUIUpload-upload_feature-L111.png

webUIUpload-upload_feature-L111.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear force-pushed the space-quota branch 2 times, most recently from 25a36a7 to 046ed01 Compare March 3, 2022 09:30
@ownclouders
Copy link
Contributor

Results for oC10Files5 https://drone.owncloud.com/owncloud/web/23215/20/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10IntegrationNotifications https://drone.owncloud.com/owncloud/web/23215/70/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review March 3, 2022 09:37
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23218/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44

@JammingBen
Copy link
Collaborator

Works well for me, one small detail I've found: Some options are hidden because the dropdown does not exceed the modal window.

image

@AlexAndBear
Copy link
Contributor Author

@JammingBen thx for feedback, problem with dropdown is in ods, @pascalwengerter opened a pr

@AlexAndBear AlexAndBear requested a review from kulmann March 3, 2022 11:58
@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/23228/72/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:111

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23228/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:143

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23271/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:57

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23271/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:65

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23271/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23271/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:56

kulmann
kulmann requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nitpicks 🙈

packages/web-app-files/tests/unit/components/Spaces/ReadmeContentModal.spec.js Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-space-quota Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/spaces/actions/editQuota.js Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Project.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/Spaces/QuotaModal.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/Spaces/QuotaModal.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann March 4, 2022 16:30
kulmann
kulmann approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb 👌 🥇

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.6% 63.6% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait3 https://drone.owncloud.com/owncloud/web/23304/46/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:33

@AlexAndBear AlexAndBear merged commit e88f2e0 into master Mar 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-quota branch March 5, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Space quota
4 participants
@AlexAndBear @ownclouders @JammingBen @kulmann