Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Shares overview page #6512

Merged
merged 2 commits into from
Mar 8, 2022
Merged

[full-ci] Shares overview page #6512

merged 2 commits into from
Mar 8, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Mar 2, 2022 •
edited
Loading

Related Issue

To-Dos

  • Discuss a11y implications of mobile version
  • active link variation (primary for active link, passive for inactive ones) doesn't work and I don't get why
  • Add unit tests for new component
  • Update acceptance tests

@update-docs
Copy link

update-docs bot commented Mar 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter marked this pull request as draft March 2, 2022 17:01
@pascalwengerter pascalwengerter changed the title Shares overview page [full-ci] Shares overview page Mar 3, 2022
@pascalwengerter pascalwengerter force-pushed the shares-overview branch 4 times, most recently from 8a2ef19 to f6af398 Compare March 3, 2022 16:40
@ownclouders
Copy link
Contributor

Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23240/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

@ownclouders
Copy link
Contributor

Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/23240/30/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersToRootShareWithPage-shareWithUsers_feature-L52.png

webUISharingInternalUsersToRootShareWithPage-shareWithUsers_feature-L52.png

@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23240/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oC10Files4 https://drone.owncloud.com/owncloud/web/23240/19/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesDetails-fileDetails_feature-L142.png

webUIFilesDetails-fileDetails_feature-L142.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23240/61/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23240/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23240/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/23240/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesDetails-fileDetails_feature-L142.png

webUIFilesDetails-fileDetails_feature-L142.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23240/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:84
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23240/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/23240/16/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-favoritesFile_feature-L74.png

webUIFavorites-favoritesFile_feature-L74.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23240/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

@pascalwengerter pascalwengerter marked this pull request as ready for review March 8, 2022 14:20
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23398/61/1
The following scenarios passed on retry:

  • webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23398/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/23398/16/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-favoritesFile_feature-L74.png

webUIFavorites-favoritesFile_feature-L74.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23398/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

kulmann
kulmann approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23408/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23408/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/23408/16/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-favoritesFile_feature-L74.png

webUIFavorites-favoritesFile_feature-L74.png

@pascalwengerter
Introduce Shares overview page
2854ebf 
Introduce `active` property for navItems in shares navigation

The `active` property that's being used in the template was simply
missing in the navItems. Added it and used the chance to switch over to
composition API for the new SharesNavigation component.

Use $gettext in template directly

Not needed to define it in setup function

Finalize SharesNavigation component && adjust tests
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.1% 67.1% Coverage
28.2% 28.2% Duplication

@pascalwengerter pascalwengerter merged commit c81ee52 into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the shares-overview branch March 8, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Shares" overview
3 participants
@pascalwengerter @ownclouders @kulmann