Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the stored space object after members have been changed #6545

Merged
merged 7 commits into from
Mar 7, 2022
Merged

Update the stored space object after members have been changed #6545

merged 7 commits into from
Mar 7, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 7, 2022 •
edited
Loading

Description

We now update the stored space after its members have been changed. Also, the permission-object of a built space has been simplified in the course of this.

Currently the only way to update the space object is by fetching the space again because the response from the OCS-API gives us no usable information. As soon as UUIDs have been introduced to the OCS-API, we could use those instead.

Note that there is still a caching bug in OCIS. E.g. when navigating between space's share panels via the share indicator, and adding/removing members, and then switching back and forth between the share panels again, the change seems to be lost. A reload reveals that this is actually not the case.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen changed the title Update space store Update the stored space object after members have been changed Mar 7, 2022
@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23351/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23351/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:84

@JammingBen JammingBen marked this pull request as ready for review March 7, 2022 13:44
@JammingBen JammingBen self-assigned this Mar 7, 2022
kulmann
kulmann requested changes Mar 7, 2022
View reviewed changes
packages/web-app-files/src/helpers/resources.js Outdated Show resolved Hide resolved
packages/web-app-files/src/store/actions.js Outdated Show resolved Hide resolved
kulmann
kulmann requested changes Mar 7, 2022
View reviewed changes
packages/web-app-files/src/helpers/resources.js Outdated Show resolved Hide resolved
packages/web-app-files/src/helpers/resources.js Outdated Show resolved Hide resolved
@JammingBen JammingBen requested a review from kulmann March 7, 2022 15:48
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23362/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:46

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23362/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44

kulmann
kulmann approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23365/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@JammingBen JammingBen merged commit 8c2049f into master Mar 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-space-store branch March 7, 2022 17:44
@JammingBen JammingBen mentioned this pull request Mar 8, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @kulmann