Prevent the member count inside a space from disappearing

changelog/unreleased/bugfix-space-member-count

@@ -0,0 +1,5 @@
+Bugfix: Prevent the member count inside a space from disappearing
+
+We've fixed a bug where opening the sidebar for a file inside a space caused the member count of the space to disappear.
+
+https://github.com/owncloud/web/pull/6550

packages/web-app-files/src/views/spaces/Project.vue

@@ -71,15 +71,15 @@
                 </oc-drop>
               </div>
               <oc-button
-                v-if="!loadSharesTask.isRunning && currentFileOutgoingCollaborators.length"
+                v-if="memberCount"
                 :aria-label="$gettext('Open context menu and show members')"
                 appearance="raw"
                 @click="openSidebarSharePanel"
               >
                 <oc-icon name="group" fill-type="line" size="small" />
                 <span
                   class="space-overview-people-count oc-text-small"
-                  v-text="peopleCountString"
+                  v-text="memberCountString"
                 ></span>
               </oc-button>
             </div>
@@ -271,18 +271,9 @@ export default {
       })
     })
 
-    const loadSharesTask = useTask(function* (signal, ref) {
-      yield ref.loadCurrentFileOutgoingShares({
-        client: graphClient,
-        path: ref.space.id,
-        space: ref.space
-      })
-    })
-
     return {
       space,
       loadResourcesTask,
-      loadSharesTask,
       resourceTargetLocation: createLocationSpaces('files-spaces-project'),
       paginatedResources,
       paginationPages,
@@ -309,8 +300,7 @@ export default {
       'selectedFiles',
       'currentFolder',
       'totalFilesCount',
-      'totalFilesSize',
-      'currentFileOutgoingCollaborators'
+      'totalFilesSize'
     ]),
 
     selected: {
@@ -339,15 +329,15 @@ export default {
     displayThumbnails() {
       return !this.configuration.options.disablePreviews
     },
-    peopleCountString() {
-      const translated = this.$ngettext(
-        '%{count} member',
-        '%{count} members',
-        this.currentFileOutgoingCollaborators.length
-      )
+    memberCount() {
+      const roles = Object.values(this.space.spaceRoles)
+      return roles.reduce((arr, obj) => arr.concat(obj), []).length
+    },
+    memberCountString() {
+      const translated = this.$ngettext('%{count} member', '%{count} members', this.memberCount)
 
       return this.$gettextInterpolate(translated, {
-        count: this.currentFileOutgoingCollaborators.length
+        count: this.memberCount
       })
     },
     quotaModalIsOpen() {
@@ -419,7 +409,6 @@ export default {
   },
   async mounted() {
     await this.loadResourcesTask.perform(this, false, this.$route.params.item || '')
-    this.loadSharesTask.perform(this)
 
     if (this.markdownResizeObserver) {
       this.markdownResizeObserver.unobserve(this.$refs.markdownContainer)

packages/web-app-files/tests/unit/views/spaces/Project.spec.js

@@ -39,6 +39,7 @@ const spaceMocks = {
   spaceWithReadmeAndImage: {
     id: 1,
     name: 'space',
+    root: { permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }] },
     special: [
       {
         specialFolder: { name: 'readme' },
@@ -55,6 +56,7 @@ const spaceMocks = {
   spaceWithoutReadmeAndImage: {
     id: 1,
     name: 'space',
+    root: { permissions: [{ roles: ['manager'], grantedTo: [{ user: { id: 1 } }] }] },
     special: []
   }
 }