Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Move OcStatusIndicators in separate column #6552

Merged
merged 2 commits into from
Mar 10, 2022
Merged

[full-ci] Move OcStatusIndicators in separate column #6552

merged 2 commits into from
Mar 10, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Mar 8, 2022 •
edited by pascalwengerter
Loading

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/23405/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter changed the title Move OcStatusIndicators in seperate column Move OcStatusIndicators in separate column Mar 9, 2022
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/23451/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter changed the title Move OcStatusIndicators in separate column [full-ci] Move OcStatusIndicators in separate column Mar 9, 2022
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23453/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:56

pascalwengerter
pascalwengerter reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking pretty neat already, the only failures in the acceptance tests are in the portrait (=tablet) mode, let's discuss tomorrow how to deal with those!

@ownclouders
Copy link
Contributor

Results for oC10SharingPermToRoot https://drone.owncloud.com/owncloud/web/23528/35/1
The following scenarios passed on retry:

  • webUISharingPermissionToRoot/sharePermissionsUsers.feature:112

@pascalwengerter pascalwengerter marked this pull request as ready for review March 10, 2022 16:15
@pascalwengerter
Copy link
Contributor

@lookacat I marked this as ready for review since that's the case, from my side. Last commit should exclude failing tests on tablet resolution, webUITrashbinRestore/trashbinRestore.feature:14 is just pretty flaky (at least locally had a ~70% success chance). I'd ask @kulmann for a review since I contributed here myself

@lookacat @pascalwengerter
Move OcStatusIndicators in seperate column
8670a3a 
Add changelog

Add changelog

Update changelog
kulmann
kulmann approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23536/36/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@pascalwengerter
Code cleanup & bump ODS to v13.0.0-rc.2
91b459e 
Disable shareIndicator tests on tablet resolution

Disable shareIndicator tests on tablet resolution
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23541/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23541/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-10-05-13-43.zip

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
46.7% 46.7% Duplication

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23544/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@kulmann kulmann merged commit 9ce5a1a into master Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the move-share-indicators branch March 10, 2022 18:05
@saw-jan saw-jan mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move share indicators into their own column
4 participants
@lookacat @ownclouders @pascalwengerter @kulmann