New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu in public links #6558

Merged

kulmann merged 1 commit into master from fix-public-links-context-menu

Mar 9, 2022

Member

kulmann commented Mar 9, 2022

Description

The context menu in public links file lists was broken due to an initialization issue of the new thumbnailService. This PR only fixes the symptom, not the initialization which is still not being called. Context menu is functional again.

Motivation and Context

Hardening

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:


          Fix context menu in public links

9f1cdbc

kulmann requested review from pascalwengerter and fschade as code owners

March 9, 2022 10:51

pascalwengerter approved these changes

View reviewed changes

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

88.9% Coverage
0.0% Duplication

Contributor

ownclouders commented Mar 9, 2022

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23427/60/1
The following scenarios passed on retry:

webUISharingInternalUsers/shareWithUsers.feature:342

Contributor

ownclouders commented Mar 9, 2022

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23427/67/1
The following scenarios passed on retry:

webUISharingPublicBasic/publicLinkCreate.feature:190

kulmann merged commit ae0f1ed into master

delete-merged-branch bot deleted the fix-public-links-context-menu branch

March 9, 2022 11:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet