Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Owncloud sdk files trash adjustments #6566

Merged
merged 34 commits into from
Mar 17, 2022
Merged

[full-ci] Owncloud sdk files trash adjustments #6566

merged 34 commits into from
Mar 17, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 10, 2022 •
edited
Loading

Description

  • Adjust to owncloud-sdk 3.0.0-alpha.1
  • Change trash bin route from files/trash to files/trash/personal
  • Add spaces trash bin
  • Add confirmation dialog for 'Empty trash' action
  • Include unused-imports plugin for linter

image
image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 10, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the owncloud-sdk-filesTrash-adjustments branch from 1a07a57 to 6d4773f Compare March 10, 2022 12:30
@AlexAndBear AlexAndBear mentioned this pull request Mar 11, 2022
Closed
@AlexAndBear AlexAndBear force-pushed the owncloud-sdk-filesTrash-adjustments branch 5 times, most recently from cedaa07 to 1e6bdd6 Compare March 14, 2022 09:36
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait3 https://drone.owncloud.com/owncloud/web/23651/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23678/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23678/tracing/alice-shares-file-to-brian-alice-2022-3-15-12-49-01.zip

@AlexAndBear AlexAndBear force-pushed the owncloud-sdk-filesTrash-adjustments branch from d5ca5cb to 984d560 Compare March 15, 2022 13:40
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23689/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23689/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-15-02-11-35.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23689/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-15-02-11-43.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23695/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23695/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-15-02-48-37.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23695/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-15-02-48-54.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23695/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-15-02-49-00.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23695/tracing/alice-shares-file-to-brian-alice-2022-3-15-02-50-23.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23695/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-15-02-51-47.zip

@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23699/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinDelete-trashbinDelete_feature-L99.png

webUITrashbinDelete-trashbinDelete_feature-L99.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear force-pushed the owncloud-sdk-filesTrash-adjustments branch from b989ab9 to ed4e8e0 Compare March 16, 2022 08:13
@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23736/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinDelete-trashbinDelete_feature-L99.png

webUITrashbinDelete-trashbinDelete_feature-L99.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear
Copy link
Contributor Author

Well this was expected =)

@AlexAndBear AlexAndBear marked this pull request as ready for review March 16, 2022 09:05
JammingBen
JammingBen requested changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor first findings. Also, spaceId needs to be storageId now. I didn't mark those occurrences, a search & replace should do.

packages/web-app-files/src/components/Trashbin.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/actions/emptyTrashBin.js Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/actions/emptyTrashBin.js Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/Trashbin.vue Outdated Show resolved Hide resolved
@JammingBen
Copy link
Collaborator

I thought there will be a PR to address this in the first place?

Yesss, was merged already: #6602

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23741/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-09-31-13.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-09-31-41.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-shares-file-to-brian-alice-2022-3-16-09-33-04.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-shares-file-to-brian-brian-2022-3-16-09-33-12.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23741/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-shares-file-to-brian-alice-2022-3-16-09-33-10.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-09-34-28.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23741/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-16-09-34-36.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23744/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-09-53-58.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-09-54-16.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-16-09-54-22.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-shares-file-to-brian-alice-2022-3-16-09-55-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-09-57-06.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23744/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-16-09-57-14.zip

@AlexAndBear AlexAndBear changed the title Owncloud sdk files trash adjustments [full-ci] Owncloud sdk files trash adjustments Mar 16, 2022
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23747/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23747/tracing/alice-shares-file-to-brian-alice-2022-3-16-10-22-41.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23747/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-10-24-03.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23747/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-16-10-24-13.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23751/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-10-44-00.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-10-44-21.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-16-10-44-29.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-shares-file-to-brian-alice-2022-3-16-10-46-07.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-shares-file-to-brian-brian-2022-3-16-10-46-18.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23751/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-10-47-18.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23754/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23754/tracing/alice-shares-file-to-brian-alice-2022-3-16-11-08-07.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23754/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-11-09-41.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23754/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-16-11-09-52.zip

@ownclouders
Copy link
Contributor

Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/23775/28/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRoot/shareWithGroups.feature:70

@AlexAndBear AlexAndBear self-assigned this Mar 16, 2022
@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23775/36/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:106

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23775/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23777/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23777/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-10-53-57.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23777/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-10-54-19.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23777/tracing/folder-alice-2022-3-16-10-52-17.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23777/tracing/folder-brian-2022-3-16-10-52-25.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23778/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23778/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-11-22-44.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23778/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-11-23-12.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23778/tracing/folder-alice-2022-3-16-11-20-29.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23778/tracing/folder-brian-2022-3-16-11-20-40.zip

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.9% 57.9% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23779/68/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/shareByPublicLink.feature:107

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23779/36/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23779/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17
  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@pascalwengerter pascalwengerter merged commit c56a335 into master Mar 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the owncloud-sdk-filesTrash-adjustments branch March 17, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbsbdr tbsbdr tbsbdr left review comments

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop Trash bin UI for Spaces No confirmation dialog for moving files to the trash
5 participants
@AlexAndBear @ownclouders @JammingBen @pascalwengerter @tbsbdr