Fix resize observer errors within subfolders of a space #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This observer thing is killing me 🥇 |
AlexAndBear
approved these changes
Mar 10, 2022
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23498/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23498/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-10-10-36-38.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23498/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-10-10-36-59.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23498/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-10-10-37-08.zip |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23505/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23505/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-10-11-18-44.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23505/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-10-11-19-08.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23505/tracing/alice-shares-file-to-brian-alice-2022-3-10-11-20-28.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23505/tracing/alice-shares-file-to-brian-brian-2022-3-10-11-20-36.zip |
JammingBen
force-pushed
the
fix-resize-observer-warnings
branch
from
9735864
to
5dc6a94
Compare
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23511/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23511/tracing/alice-shares-file-to-brian-alice-2022-3-10-11-57-18.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23511/tracing/alice-shares-file-to-brian-brian-2022-3-10-11-57-28.zip |
|
I have absolutely no clue why the e2e tests keep failing. It has literally nothing to do with this change 🤔 |
kulmann
approved these changes
Mar 10, 2022
|
Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/23534/57/1 |
|
Kudos, SonarCloud Quality Gate passed! |
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23538/66/1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed a bug where the resize observer crashes within subfolders of a space because there is no element to observe.
Types of changes
Checklist: