Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sharing tab style & add icons #6573

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Improve sharing tab style & add icons #6573

merged 4 commits into from
Mar 11, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Mar 10, 2022 •
edited
Loading

Related Issue

Screenshots

Desktop/Tablet

Screenshot 2022-03-11 at 12-02-47 Files shared with me - ownCloud

Mobile

Screenshot 2022-03-11 at 12 03 10

@update-docs
Copy link

update-docs bot commented Mar 10, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23522/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

XPath selector //nav[@id="shares-navigation"]/ul/li/a[.="Shared with others" doesn't work anymore because it also includes an icon now. Need to go down to the span. But the selector looks a bit too strict to me, can be less strict like this:
//nav[@id="shares-navigation"]//*[.="Shared with others"]

@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

Could you include a screenshot in the PR description?

@kulmann kulmann self-requested a review March 10, 2022 16:30
@pascalwengerter
Copy link
Contributor Author

Could you include a screenshot in the PR description?

Done

@pascalwengerter
Copy link
Contributor Author

XPath selector //nav[@id="shares-navigation"]/ul/li/a[.="Shared with others" doesn't work anymore because it also includes an icon now. Need to go down to the span. But the selector looks a bit too strict to me, can be less strict like this: //nav[@id="shares-navigation"]//*[.="Shared with others"]

Included, good hint, thx!

@pascalwengerter pascalwengerter mentioned this pull request Mar 11, 2022
Closed
5 tasks
kulmann
kulmann reviewed Mar 11, 2022
View reviewed changes
packages/web-app-files/src/components/AppBar/SharesNavigation.vue Outdated
@@ -56,17 +61,21 @@ export default {
return routes
}, {})
const navItems = computed(() => [
// computed aka not reactive?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev leftover? computed -> immutable (at least not via setting a value)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, that was my reminder to investigate what later "magically" worked 🤷🏽 removing it

kulmann
kulmann approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23586/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23586/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:93

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23586/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@kulmann kulmann merged commit abf8919 into master Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-shares-tab-style branch March 11, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design: Shares overview Tabs
3 participants
@pascalwengerter @ownclouders @kulmann