[full-ci] Sprint 16 design fixes #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookacat
force-pushed
the
sprint-16-design-fixes
branch
from
c6d03b0
to
9b15efa
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23646/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23646/tracing/alice-shares-file-to-brian-alice-2022-3-14-01-38-02.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23646/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-14-01-39-18.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23646/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-14-01-39-26.zip |
lookacat
force-pushed
the
sprint-16-design-fixes
branch
4 times, most recently
from
ca82e51
to
33ed49b
Compare
pascalwengerter
force-pushed
the
sprint-16-design-fixes
branch
from
31df9b5
to
ab1e8f1
Compare
Linting & Update tests Fixes after rebase
|
Rebased, I'll do a code review now since @lookacat took over this PR eventually |
kulmann
requested changes
Mar 17, 2022
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
kulmann
previously approved these changes
Mar 17, 2022
|
This PR isn't ready yet, please don't merge |
pascalwengerter
commented
Mar 17, 2022
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
pascalwengerter
commented
Mar 17, 2022
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23819/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23819/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-17-12-41-33.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23819/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-17-12-41-54.zip |
roger, dismissed by review |
kulmann
requested changes
Mar 17, 2022
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/SelectedResources/SizeInfo.vue
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Mar 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue