Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish ViewOptions hover effect #6591

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Polish ViewOptions hover effect #6591

merged 4 commits into from
Mar 15, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Mar 14, 2022

Description

See #6492

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Screenshots

Screenshot (5)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review March 14, 2022 10:06
@kulmann
Copy link
Member

kulmann commented Mar 14, 2022

Could you include screenshots in your PR description? (in fact that always makes sense when you work on polishing issues 😉 )

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23660/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23660/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@lookacat lookacat merged commit ecf90a4 into master Mar 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the polish-viewoptions-hover branch March 15, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants