Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] Fix waitForFileVisible function #6595

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[full-ci][tests-only] Fix waitForFileVisible function #6595

merged 2 commits into from
Mar 28, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Mar 15, 2022 •
edited
Loading

Description

The issue with #6594 was that different files/folders were selected for actions.
This was due to scrolling from waitForFileVisible. Custom scrolling is not required as the Nightwatch APIs will scroll elements into view before performing actions.

Related Issue

Fixes #6594

Motivation and Context

How Has This Been Tested?

  • test environment: local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan changed the title [do-not-merge][full-ci][tests-only] Run acceptance tests only and check all failing tests [do-not-merge][full-ci][tests-only] Run only acceptance tests and check all failing tests Mar 15, 2022
@saw-jan saw-jan changed the title [do-not-merge][full-ci][tests-only] Run only acceptance tests and check all failing tests [do-not-merge][full-ci][tests-only] Run acceptance tests only and check all failing tests Mar 15, 2022
@ownclouders
Copy link
Contributor

Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/23655/51/1
The following scenarios passed on retry:

  • webUIRenameFiles/renameFiles.feature:257

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23661/54/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@saw-jan saw-jan changed the title [do-not-merge][full-ci][tests-only] Run acceptance tests only and check all failing tests [full-ci][tests-only] Fix waitForFileVisible function Mar 15, 2022
@saw-jan saw-jan self-assigned this Mar 15, 2022
@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23672/65/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@saw-jan saw-jan marked this pull request as ready for review March 15, 2022 11:37
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23675/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-15-11-50-31.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-15-11-50-48.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-15-11-50-55.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-shares-file-to-brian-alice-2022-3-15-11-52-19.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-15-11-53-38.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23675/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-15-11-53-46.zip

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23737/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:46

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23737/36/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23737/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:62

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23737/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:98

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23745/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23745/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-09-59-46.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23745/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-10-00-03.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23745/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-16-10-00-09.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23745/tracing/alice-shares-file-to-brian-alice-2022-3-16-10-01-32.zip

SwikritiT
SwikritiT reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23767/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23767/tracing/alice-shares-file-to-brian-alice-2022-3-16-03-16-46.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23768/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23768/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-03-39-15.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23768/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-03-39-33.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23768/tracing/alice-shares-file-to-brian-alice-2022-3-16-03-41-01.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23768/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-03-42-19.zip

@saw-jan
Copy link
Member Author

saw-jan commented Mar 17, 2022

@phil-davis @individual-it @pascalwengerter
The related tests are not so intermittent on the current master. This PR cleans some unwanted codes which were causing some issues before. It is good to remove unwanted codes.
What do you guys think about this PR?

@pascalwengerter
Copy link
Contributor

@saw-jan I'll restart CI, if the acceptance tests are green I'm in favor of merging it, yes 😉

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23796/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23796/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-17-10-11-31.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23796/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-17-10-11-54.zip

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23801/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:188

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23801/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23801/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:279

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23801/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/23856/48/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23856/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:169

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23856/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:115
  • webUITrashbinRestore/trashbinRestore.feature:84

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23856/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:61
  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:62

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23856/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@saw-jan
Copy link
Member Author

saw-jan commented Mar 18, 2022

A lot of passes on retry. Not so confident to merge it now. I will look into those passes on retry

@saw-jan saw-jan marked this pull request as draft March 18, 2022 04:33
@saw-jan saw-jan force-pushed the failing-acceptance-tests branch 3 times, most recently from 72af130 to 46eb1a7 Compare March 23, 2022 05:29
@saw-jan saw-jan marked this pull request as ready for review March 23, 2022 06:05
@saw-jan
Copy link
Member Author

saw-jan commented Mar 23, 2022

@pascalwengerter Could you review?
Currently, there are no passes on retry.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 24, 2022 •
edited
Loading

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/24113/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 6a1a071 into master Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the failing-acceptance-tests branch March 28, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@individual-it individual-it individual-it approved these changes

@fschade fschade Awaiting requested review from fschade

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@Talank Talank Awaiting requested review from Talank

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Acceptance test webUITrashbinFilesFolders/trashbinFilesFolders.feature:23 is failing in XGAPortrait
5 participants
@saw-jan @ownclouders @pascalwengerter @individual-it @SwikritiT