Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource loading within spaces #6601

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 15, 2022

Description

I recently noticed some issues when navigating within spaces when is comes to loading the image & readme also also (once again) the resize observer. So I improved the loading of resources within a space. This enhances performance and overall stability within spaces.

  • A new parameter was introduced to determine if a space needs to be fetched or not. Route changes within a space do not require the space to be fetched again. This also ensures that the space image and readme won't be fetched in subfolders.
  • The space now gets set at the end of the loading task. This ensures that the space task has finished as soon as the image and readme get loaded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 15, 2022
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23679/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23679/tracing/alice-shares-file-to-brian-alice-2022-3-15-12-59-09.zip

@JammingBen JammingBen marked this pull request as ready for review March 17, 2022 10:12
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Mar 17, 2022
@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23803/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23811/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23811/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23818/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23818/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen removed the Status:Needs-Review Needs review from a maintainer label Mar 18, 2022
@JammingBen JammingBen merged commit 06c1ef2 into master Mar 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-resource-loading branch March 18, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants