Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the share inheritance indicators #6613

Merged
merged 5 commits into from
Mar 21, 2022
Merged

Implement the share inheritance indicators #6613

merged 5 commits into from
Mar 21, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Mar 17, 2022 •
edited
Loading

Description

We've implemented the share inheritance indicators in the share sidebar panel. They indicate whether a resource is shared indirectly via one of its parent folders.

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 17, 2022
@kulmann
Copy link
Member

kulmann commented Mar 17, 2022

What do you think about Navigate to parent folder as wording? parent is not necessarily a direct parent and it's IMO easier to read/understand.

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23822/61/1
The following scenarios passed on retry:

  • webUIResharing1/reshareUsers.feature:214

@ownclouders
Copy link
Contributor

Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/23822/30/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@owncloud owncloud deleted a comment from update-docs bot Mar 17, 2022
@JammingBen JammingBen marked this pull request as ready for review March 18, 2022 13:07
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Mar 18, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Mar 18, 2022 •
edited
Loading

Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/23931/30/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

78.6% 78.6% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit be7b1ce into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the share-inheritance-indicators branch March 21, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share List: Add inheritance-indicators
3 participants
@JammingBen @kulmann @ownclouders