[full-ci] Remove contextRouteName from app params and add it to the query instead #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
force-pushed
the
context_route
branch
2 times, most recently
from
a88e97a
to
4333a24
Compare
pascalwengerter
approved these changes
Mar 18, 2022
|
SonarCloud Quality Gate failed. |
dschmidt
changed the title
kulmann
reviewed
Mar 21, 2022
| const isPublicLinkContext = computed(() => { | ||
| return unref(currentRoute).params.contextRouteName === 'files-public-files' | ||
| return unref(currentRoute).query[contextRouteNameKey] === 'files-public-files' |
There was a problem hiding this comment.
Did you see the useRouteQuery composable? 🤔
kulmann
reviewed
Mar 21, 2022
| const isPublicLinkContext = computed(() => { | ||
| return unref(currentRoute).params.contextRouteName === 'files-public-files' | ||
| return unref(currentRoute).query[contextRouteNameKey] === 'files-public-files' |
There was a problem hiding this comment.
Did you see the useRouteQuery composable? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes
contextRouteNamefrom app parameters. It's handled fully automatically in the url query, so apps can just use the provideduseAppDefaultscomposable and don't need to mess with urls themselves for something they really should not have to care about.Nice sideeffect is that it's now visible further in the back of the url and hopefully less confusing for users.
Related Issue
Motivation and Context
Make everything more streamlined and straightforward for developing file editors/viewers.
I've also taken care that changing the query item name is also just a two line patch, as we plan to adjust the naming in the near future.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: