Fix natural sort order #6632
Merged
Fix natural sort order #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23957/71/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIPrivateLinks-accessingPrivateLinks_feature-L17.png |
|
Kudos, SonarCloud Quality Gate passed! |
pascalwengerter
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sorting to respect natural sort order again. Also used the chance to switch over to
Intl.Collatorwhich is considered to be a performance improvement, compared tolocaleCompare.Related Issue
How Has This Been Tested?
Added an example for non-natural order being sorted to natural sort order to the existing unit test for the sorting composable.
Types of changes
Checklist: