Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] fix log output of unit test in FileShares.spec #6722

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

individual-it
Copy link
Member

Description

fix unit test log output of FileShares.spec.js

Related Issue

Motivation and Context

get rid of these log outputs, make the tests work correctly

  console.error
    [Vue warn]: The setup binding property "sharesLoading" is already declared.

    found in

    ---> <FileShares>
           <Root>

      at Object.warn (node_modules/vue/dist/vue.runtime.common.dev.js:621:15)
      at warn (node_modules/@vue/composition-api/dist/vue-composition-api.common.js:427:18)
      at asVmProperty (node_modules/@vue/composition-api/dist/vue-composition-api.common.js:1764:13)
      at node_modules/@vue/composition-api/dist/vue-composition-api.common.js:2006:17
          at Array.forEach (<anonymous>)
      at initSetup (node_modules/@vue/composition-api/dist/vue-composition-api.common.js:1982:39)
      at VueComponent.wrappedData (node_modules/@vue/composition-api/dist/vue-composition-api.common.js:1943:13)

How Has This Been Tested?

running tests locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pascalwengerter pascalwengerter merged commit 92199f7 into master Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixUnitTestLogsFileShares branch April 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants