Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Redesign "Create and manage sharing links" #6749

Merged
merged 2 commits into from
Apr 27, 2022
Merged

[full-ci] Redesign "Create and manage sharing links" #6749

merged 2 commits into from
Apr 27, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Apr 7, 2022 •
edited
Loading

@update-docs
Copy link

update-docs bot commented Apr 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter force-pushed the redesign-sidebar-public-links branch 2 times, most recently from 0acaf89 to 55c88a6 Compare April 13, 2022 09:51
@pascalwengerter pascalwengerter changed the title WIP: Redesign "Create and manage sharing links" [full-ci] Redesign "Create and manage sharing links" Apr 13, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 13, 2022 •
edited
Loading

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/24921/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L32.png

webUISharingPublicBasic-publicLinkEdit_feature-L32.png

@pascalwengerter pascalwengerter mentioned this pull request Apr 19, 2022
Closed
@pascalwengerter pascalwengerter mentioned this pull request Apr 25, 2022
Merged
kulmann
kulmann requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments. feels good so far!
additional issues:

  • selected date in date picker of public link doesn't get applied anymore (blocking for merge)
  • options dropdown for a link list item feels a bit too compact, but can be solved later on

changelog/unreleased/enhancement-update-ods Outdated Show resolved Hide resolved
.drone.star Outdated Show resolved Hide resolved
.drone.star Outdated Show resolved Hide resolved
packages/web-app-files/src/helpers/share/role.ts Outdated Show resolved Hide resolved
tests/acceptance/stepDefinitions/publicLinkContext.js Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Outdated Show resolved Hide resolved
@pascalwengerter pascalwengerter force-pushed the redesign-sidebar-public-links branch 2 times, most recently from 9e064c0 to 9c3262f Compare April 25, 2022 18:15
@fschade fschade mentioned this pull request Apr 26, 2022
Closed
25 tasks
@pascalwengerter pascalwengerter force-pushed the redesign-sidebar-public-links branch 4 times, most recently from 3f44521 to d67147a Compare April 26, 2022 11:41
fschade
fschade requested changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some minor things, many of my findings are optional and just my personal opinion. I really do love how much you have decluttered some parts! Thanks :)

i haven't looked into the dests too much, overall a pretty good step forward. I've only reviewed to code in ide for now and will test it in the browser tomorrow once the ci is green.

packages/web-app-files/src/components/SideBar/Shares/Links/CreateForm.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/CreateForm.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/CreateForm.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/CreateForm.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Links/CreateForm.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue Show resolved Hide resolved
packages/web-app-files/src/helpers/resources.ts Show resolved Hide resolved
@pascalwengerter pascalwengerter marked this pull request as ready for review April 27, 2022 09:53
fschade
fschade approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pascalwengerter
Redesign link list components to include inline edit & event driven a…
e882806 
…rchitecture

Address code review

Fix remaining acceptance tests

Remove unused error boolean & alert on CreateLink form component

Check for ReadWriteDelete password enforcement

Include #6808
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

37.3% 37.3% Coverage
3.7% 3.7% Duplication

kulmann
kulmann requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last remaining thing: public links can't be modified anymore because there is a malformed DateTime creation. Otherwise LGTM, will approve after that's fixed.

kulmann
kulmann approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. Couldn't reproduce the DateTime conversion issue anymore. Super happy to have this merged! Feels so well aligned with regular shares now, regarding their look and feel 🤩

@kulmann kulmann merged commit 726b390 into master Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-sidebar-public-links branch April 27, 2022 12:49
@pascalwengerter pascalwengerter mentioned this pull request Apr 29, 2022
Closed
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking for password enforcement on public links is utterly broken
4 participants
@pascalwengerter @ownclouders @kulmann @fschade