Add Contextual Helpers #6750
Merged
Add Contextual Helpers #6750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
force-pushed
the
add-contextual-helpers
branch
2 times, most recently
from
73e0baf
to
10dd5f8
Compare
|
Results for oC10SharingIntGroupsToRoot https://drone.owncloud.com/owncloud/web/24797/29/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases_feature-L37.png |
pascalwengerter
requested changes
Apr 21, 2022
| class="oc-mt-xs oc-text-meta" | ||
| v-text="inviteDescriptionMessage" | ||
| /> | ||
| <oc-contextual-helper v-if="resourceIsSpace && helpersEnabled" v-bind="spaceAddMemberHelp" /> |
There was a problem hiding this comment.
Would it make sense to reduce this to one OcContextualHelper with only v-if="helpersEnabled" and handle the spaces differentiation in the v-bind computed property?
Add contextual helpers for shares sidebar add changelog Bump ODS Update snapshots Make contextHelpers configurable ODS Bump changelog
lookacat
force-pushed
the
add-contextual-helpers
branch
from
c85c246
to
2fa0478
Compare
|
Kudos, SonarCloud Quality Gate passed! |
pascalwengerter
approved these changes
Apr 21, 2022
|
can't see the helpers - where have they gone? |
Fixed in #7084 by making them opt-out (I guess oCIS never opted in in the first place) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #6590
Related Issue
Screenshots:
Types of changes
Checklist: