Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest share enhancements #6813

Merged
merged 14 commits into from
Apr 27, 2022
Merged

Guest share enhancements #6813

merged 14 commits into from
Apr 27, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 26, 2022

Description

NOTE: For oc10, this requires a higher ownCloud 10 version than 10.9.1

Bugfix: Indicate guest shares

We've fixed a bug, where guest shares were not correctly indicated and shown as users shares
at the share panel in the right sidebar.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review April 26, 2022 18:15
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 😎

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

37.8% 37.8% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 7a06e0b into master Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the guest-shares branch April 27, 2022 10:57
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Guests are displayed as "Users"
2 participants