[full-ci] Set document title consistently for all apps in useAppDefaults composable #6870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
app_name_title
branch
2 times, most recently
from
6e2cc87
to
bae8532
Compare
|
Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/25272/57/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-fileFolderActionMenu_feature-L14.pngwebUIFilesActionMenu-fileFolderActionMenu_feature-L37.pngwebUIFilesActionMenu-versions_feature-L15.pngwebUIFilesActionMenu-versions_feature-L26.pngwebUIFilesActionMenu-versions_feature-L77.pngwebUIFilesDetails-fileDetails_feature-L14.pngwebUIFilesDetails-fileDetails_feature-L142.pngwebUIFilesDetails-fileDetails_feature-L146.pngwebUIFilesDetails-fileDetails_feature-L173.pngwebUIFilesDetails-fileDetails_feature-L182.pngwebUIFilesDetails-fileDetails_feature-L27.pngwebUIFilesList-fileList_feature-L15.pngwebUIFilesList-fileList_feature-L22.pngwebUIFilesList-fileList_feature-L28.pngwebUIFilesList-fileList_feature-L33.pngwebUIFilesList-fileList_feature-L42.pngwebUIFilesList-fileList_feature-L55.pngwebUIFilesList-sort_feature-L31.pngwebUIFilesList-sort_feature-L51.pngwebUIFilesList-sort_feature-L72.pngwebUIFilesSearch-search_feature-L113.pngwebUIFilesSearch-search_feature-L122.pngwebUIFilesSearch-search_feature-L139.pngwebUIFilesSearch-search_feature-L146.pngwebUIFilesSearch-search_feature-L185.pngwebUIFilesSearch-search_feature-L27.pngwebUIFilesSearch-search_feature-L38.pngwebUIFilesSearch-search_feature-L95.png |
dschmidt
force-pushed
the
app_name_title
branch
4 times, most recently
from
01d1050
to
6e6fa35
Compare
kulmann
requested changes
Jun 14, 2022
... and move makeRequest into its own composable.
|
SonarCloud Quality Gate failed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and move
makeRequestto its own composable.Description
This refactors document title setting and moves
makeRequestinto its own composable.Related Issue
Motivation and Context
How Has This Been Tested?
addAppProviderFileseems to produce the same request as before the refactor, but my ocis doesn't like either.. so I cannot be 100%. Could anyone with a working wopi setup give this a spin?Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: