Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix account-info quota rendering #6923

Merged
merged 2 commits into from
May 13, 2022
Merged

fix account-info quota rendering #6923

merged 2 commits into from
May 13, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented May 9, 2022 •
edited by butonic
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@fschade fschade requested a review from pascalwengerter as a code owner May 9, 2022 15:52
@update-docs
Copy link

update-docs bot commented May 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade force-pushed the account-info-quota branch from 331cc19 to f1c36b4 Compare May 9, 2022 15:58
@butonic butonic added the Type:Bug Something isn't working label May 11, 2022
@pascalwengerter pascalwengerter force-pushed the account-info-quota branch 3 times, most recently from 2fb691f to 4075dbe Compare May 13, 2022 11:17
pascalwengerter
pascalwengerter reviewed May 13, 2022
View reviewed changes
packages/web-runtime/src/store/user.js
@@ -263,7 +263,7 @@ const mutations = {
SET_QUOTA(state, quota) {
// Turn strings into ints
quota.free = parseInt(quota.free)
quota.relative = parseInt(quota.relative)
quota.relative = parseFloat(quota.relative)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fschade took me a bit longer because I needed to investigate why the relative used storage (which the backend reports correctly) always ends up as 0 in the store 💩 also fixed the fixtures where this was reflected, too

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit d3c8baa into master May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the account-info-quota branch May 13, 2022 12:14
This was referenced May 23, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show unlimited quota / respect quota.definition: none
3 participants
@fschade @butonic @pascalwengerter