Use oc-etag instead of etag #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
May 12, 2022
| @@ -116,8 +116,7 @@ export default { | |||
| .then( | |||
| (response) => { | |||
| serverContent.value = newContent | |||
| // FIXME: above we need response.headers.ETag, here we need response ETag - feels inconsistent | |||
There was a problem hiding this comment.
Note: I removed this comment, as it is intended, above we do a get request to a file (where the headers should contain the etag), while updating a resource the etag is emitted in the payload, which is correct
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/25524/17/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUITextEditor-textFile_feature-L21.pngwebUITextEditor-textFile_feature-L29.png |
|
Kudos, SonarCloud Quality Gate passed! |
5 tasks
pascalwengerter
approved these changes
May 12, 2022
| "owncloud-sdk@npm:~3.0.0-alpha.8": | ||
| version: 3.0.0-alpha.8 | ||
| resolution: "owncloud-sdk@npm:3.0.0-alpha.8" | ||
| "owncloud-sdk@npm:~3.0.0-alpha.9": |
There was a problem hiding this comment.
Sorry to be picky here but #6952 should be linked in the "sdk-bump" changelog item then 😬 can be done after this has been merged in a changelog-only PR though (which skips all the tests in CI)
delete-merged-branch
bot
deleted the
use-oc-etag-instead-of-etag-in-text-editor
branch
10 tasks
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: Use OC-ETag instead of ETag in text editor app
We've fixed a bug, where the ETag instead of OC-ETag in the text editor app was used,
due to server encoding, the ETag might be manipulated and contain the gzip suffix on large text files.
Saving the respective file, might cause an error, as the sent ETag doesn't match the server's ETag.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: