Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Show password prompt if role change on public link enforces password #6989

Merged
merged 1 commit into from
May 18, 2022

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Show password prompt if role change on public link enforces password [full-ci] Show password prompt if role change on public link enforces password May 17, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review May 17, 2022 09:29
@ownclouders
Copy link
Contributor

ownclouders commented May 17, 2022

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25678/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L56.png

webUISharingPublicBasic-publicLinkEdit_feature-L56.png

@pascalwengerter pascalwengerter force-pushed the issues/6974 branch 2 times, most recently from e666c2d to 61d2600 Compare May 17, 2022 16:06
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge if green (even if I collaborated 😬 ). We shouldhave follow(ed)-up and add(ed) a changelog in a separate PR

pascalwengerter added a commit that referenced this pull request May 17, 2022
pascalwengerter pushed a commit that referenced this pull request May 17, 2022
pascalwengerter pushed a commit that referenced this pull request May 17, 2022
Trigger Build

Show error message if password ist empty

Don't use imported

Fix acceptance tests

Add changelog for #6989

Sort out acceptance test line numbers
pascalwengerter pushed a commit that referenced this pull request May 17, 2022
Trigger Build

Show error message if password ist empty

Don't use imported

Fix acceptance tests

Add changelog for #6989

Sort out acceptance test line numbers

Sort out acceptance test line numbers
pascalwengerter pushed a commit that referenced this pull request May 17, 2022
Trigger Build

Show error message if password ist empty

Don't use imported

Fix acceptance tests

Add changelog for #6989

Sort out acceptance test line numbers

Sort out acceptance test line numbers

Sort out acceptance test line numbers
@pascalwengerter pascalwengerter force-pushed the issues/6974 branch 2 times, most recently from 7d9bf36 to 634d5d6 Compare May 18, 2022 06:40
Trigger Build

Show error message if password ist empty

Don't use imported

Fix acceptance tests

Add changelog for #6989

Sort out acceptance test line numbers

Sort out acceptance test line numbers

Sort out acceptance test line numbers

Sort out acceptance test line numbers
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

10.0% 10.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 475e3c5 into master May 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/6974 branch May 18, 2022 07:31
@kulmann kulmann mentioned this pull request May 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing passwordless link role to one that has an enforced password fails badly
3 participants