Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix complete-state of the upload overlay #7100

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix complete-state of the upload overlay #7100

merged 1 commit into from
Jun 8, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

We've fixed a bug where the complete-state of the upload overlay would show before the upload even started.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 8, 2022
@JammingBen JammingBen requested a review from kulmann June 8, 2022 12:06
@kulmann kulmann merged commit 3abe47b into master Jun 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-upload-overlay-complete-state branch June 8, 2022 12:53
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload-overlay displays misleading status at startup
2 participants
@JammingBen @kulmann