Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop version from sample configs and ci configs (it's unused) #7130

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 15, 2022

The version in our config.json is not used. At least not anymore. Removing it from all sample configs and CI configs.

@update-docs
Copy link

update-docs bot commented Jun 15, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested a review from wkloucek June 15, 2022 09:07
@kulmann kulmann self-assigned this Jun 15, 2022
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 5d6f401 into master Jun 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the drop-version-from-sample-configs branch June 15, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants