Add alias links to web UI

[pascalwengerter]

Description

Cleaning up my local git stash and came across this draft. Needs concepting how to properly turn this into an oCIS-only feature. Update: alias-link capability has landed in oCIS

Related Issue

• Works towards Scoped links #6844

[pascalwengerter]

This does now work on the link-creator side, but I run into problems when trying to open the (permissionless) link - I'd expect it to render the login form, but it shows an error page (with a 401 when listing drives)

[kulmann]

@pascalwengerter I took the liberty of rebasing this PR, as the public link resolving has changed in the web runtime today (see #7072 for reference). However, whenever I want to create an internal link I get invalid permissions from the backend. Can you confirm that?

[pascalwengerter]

@pascalwengerter I took the liberty of rebasing this PR, as the public link resolving has changed in the web runtime today (see #7072 for reference). However, whenever I want to create an internal link I get invalid permissions from the backend. Can you confirm that?

Did some investigation now and can confirm it doesn't work - I thought we had implemented the necessary changes in the SDK already, but getting an invalid permissions webdav response when trying to sending e.g. a "0" as zero-permission (sending nothing doesn't work because that is the standard behavior when updating links without touching permissions). I've opened an issue in the SDK

[pascalwengerter]

@pascalwengerter I took the liberty of rebasing this PR, as the public link resolving has changed in the web runtime today (see #7072 for reference). However, whenever I want to create an internal link I get invalid permissions from the backend. Can you confirm that?

Did some investigation now and can confirm it doesn't work - I thought we had implemented the necessary changes in the SDK already, but getting an invalid permissions webdav response when trying to sending e.g. a "0" as zero-permission (sending nothing doesn't work because that is the standard behavior when updating links without touching permissions). I've opened an issue in the SDK

Turns out sending a 0 permission is enough, it does work with cs3org/reva#3079 (stopped CI, this PR needs a rebase & review once Julian's PR is merged in reva and then in oCIS and the oCIS commit ID is bumped)!

[pascalwengerter]

@pascalwengerter I took the liberty of rebasing this PR, as the public link resolving has changed in the web runtime today (see #7072 for reference). However, whenever I want to create an internal link I get invalid permissions from the backend. Can you confirm that?

Did some investigation now and can confirm it doesn't work - I thought we had implemented the necessary changes in the SDK already, but getting an invalid permissions webdav response when trying to sending e.g. a "0" as zero-permission (sending nothing doesn't work because that is the standard behavior when updating links without touching permissions). I've opened an issue in the SDK

Turns out sending a 0 permission is enough, it does work with cs3org/reva#3079 (stopped CI, this PR needs a rebase & review once Julian's PR is merged in reva and then in oCIS and the oCIS commit ID is bumped)!

Ideally we also get an E2E test for alias links in oCIS to make sure they don't break unnoticed in the near future

[kulmann]

This PR handles creating internal / permissionless links, that works with updated ocis/reva as you mentioned. Respective commit id has been bumped in web already, so a rebase was sufficient. But: resolving an internal link is not handled in the public link resolve page. I'd like to merge this PR but flip the default of the capability to internal links being disabled, until we implement resolving internal links in a separate PR. Do you agree @pascalwengerter ?

[pascalwengerter]

This PR handles creating internal / permissionless links, that works with updated ocis/reva as you mentioned. Respective commit id has been bumped in web already, so a rebase was sufficient. But: resolving an internal link is not handled in the public link resolve page. I'd like to merge this PR but flip the default of the capability to internal links being disabled, until we implement resolving internal links in a separate PR. Do you agree @pascalwengerter ?

Please do push to this PR as you deem necessary, I don't have any preference on how to proceed here ;)

[JammingBen]

I rebased and updated the PR to go along with current master. No idea why the condition coverage does not cover availableRoleOptions() though. Locally, the tests call this method and reach the updated return statement 🤷

Besides that, this should be ready for review. LGTM to me, although I'm not too invested in the topic.

[kulmann]

Some nitpicks (see comments). Also: please update the ocis commit id in .drone.env to one after the alias capability value has changed in ocis.

[JammingBen]

Arghs I forgot the .drone.env, coming up next. Edit: Done.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.5% Coverage
0.0% Duplication