Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue external apps fix #7173

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Continue external apps fix #7173

merged 5 commits into from
Jun 23, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 23, 2022

Description

Continuation of #7166 which provides an option to override the application name in the document title (and using it from the external app) to reduce code duplication.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the continue-external-apps-fix branch from b39fdda to 7f9378d Compare June 23, 2022 08:54
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

52.6% 52.6% Coverage
0.0% 0.0% Duplication

@kulmann kulmann requested a review from dschmidt June 23, 2022 09:14
@kulmann kulmann merged commit 6788c4d into master Jun 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the continue-external-apps-fix branch June 23, 2022 09:51
@diocas
Copy link
Contributor

diocas commented Jun 23, 2022

Btw, later on don't forget to fix drawio as well. I didn't create a ticket for it.

@micbar micbar mentioned this pull request Jul 19, 2022
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants