Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump (peer)dependencies #7200

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[full-ci] Bump (peer)dependencies #7200

merged 2 commits into from
Aug 16, 2022

Conversation

pascalwengerter
Copy link
Contributor

Description

Supersedes some dependabot PRs and bumps the SDK's dependencies to their most recent versions (most interesting here is axios, originally had the bump included in #7139 but then had unexpected failures in the acceptance tests)

@update-docs
Copy link

update-docs bot commented Jun 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the 30062022-bump-deps branch 2 times, most recently from 27c66f6 to a4d8cf2 Compare July 28, 2022 10:14
@kulmann
Copy link
Member

kulmann commented Jul 28, 2022

@individual-it @phil-davis could you / your team have a look at this PR? I rebased it to current master. CI is failing hard. I tried the first 6 tests locally and they were all passing. Priority is low, but would be nice to get some dependencies up to date.

@saw-jan saw-jan self-assigned this Aug 2, 2022
@SagarGi SagarGi assigned SagarGi and unassigned saw-jan Aug 3, 2022
@SagarGi
Copy link
Member

SagarGi commented Aug 4, 2022

@kulmann Able to reproduce the CI failures locally. Will be digging into it.

@SagarGi
Copy link
Member

SagarGi commented Aug 4, 2022

@kulmann @phil-davis @individual-it The main reason behind the CI failure above is apparently axios version bump
While using axios 0.27.1 (bumped version) it gives an error Failed to load the setting values as a pop up notification.

(Reload with axios verison 0.27.1)

axios0.27.1.mp4

So the pop up notification seems to be the main reason for the CI failure.

When using axios version 0.26.1 there is no such pop up failure notification

(Reload with axios verison 0.26.1)

0.26.1.mp4

Need further information regarding this.

@SagarGi SagarGi requested a review from kulmann August 12, 2022 05:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Aug 16, 2022

@kulmann @phil-davis @individual-it The main reason behind the CI failure above is apparently axios version bump While using axios 0.27.1 (bumped version) it gives an error Failed to load the setting values as a pop up notification.

Thank you for the pointers. I made some changes in the code so that with an oc10 backend we will not query the settings at all anymore. That made the CI green.

@kulmann kulmann merged commit 60c2b33 into master Aug 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the 30062022-bump-deps branch August 16, 2022 09:07
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I thought I approved the PR already before. Apparently I didn't. Classic yolo 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants