Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no close option on app pdf-viewer #7201

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Fix no close option on app pdf-viewer #7201

merged 6 commits into from
Jun 30, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jun 30, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jun 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann June 30, 2022 12:30
kulmann
kulmann requested changes Jun 30, 2022
View reviewed changes
packages/web-app-pdf-viewer/src/App.vue Outdated Show resolved Hide resolved
packages/web-app-pdf-viewer/src/App.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann June 30, 2022 12:45
kulmann
kulmann approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann mentioned this pull request Jun 30, 2022
Closed
@AlexAndBear AlexAndBear merged commit c189532 into master Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7198 branch June 30, 2022 13:31
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extensions - PDF-Viewer: "cross" icon/button to close when viewing pdf.
2 participants
@AlexAndBear @kulmann