Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce app top bar #7217

Merged
merged 11 commits into from
Jul 6, 2022
Merged

Introduce app top bar #7217

merged 11 commits into from
Jul 6, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 5, 2022

Description

Enhancement: Add app top bar component

We've added a app top bar component for consistency,
which will be used by the apps: preview, text-editor and pdf-viewer.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann July 5, 2022 09:54
@ownclouders
Copy link
Contributor

ownclouders commented Jul 5, 2022

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/26662/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITextEditor-textFile_feature-L13.png

webUITextEditor-textFile_feature-L13.png

webUITextEditor-textFile_feature-L21.png

webUITextEditor-textFile_feature-L21.png

webUITextEditor-textFile_feature-L29.png

webUITextEditor-textFile_feature-L29.png

webUITextEditor-textFile_feature-L37.png

webUITextEditor-textFile_feature-L37.png

webUITextEditor-textFile_feature-L44.png

webUITextEditor-textFile_feature-L44.png

webUITextEditor-textFile_feature-L50.png

webUITextEditor-textFile_feature-L50.png

webUITextEditor-textFile_feature-L56.png

webUITextEditor-textFile_feature-L56.png

webUITextEditor-textFile_feature-L70.png

webUITextEditor-textFile_feature-L70.png

webUITextEditor-textFile_feature-L71.png

webUITextEditor-textFile_feature-L71.png

webUITextEditor-textFile_feature-L80.png

webUITextEditor-textFile_feature-L80.png

webUITextEditor-textFile_feature-L81.png

webUITextEditor-textFile_feature-L81.png

webUITextEditor-textFile_feature-L82.png

webUITextEditor-textFile_feature-L82.png

webUITextEditor-textFile_feature-L83.png

webUITextEditor-textFile_feature-L83.png

webUITextEditor-textFile_feature-L84.png

webUITextEditor-textFile_feature-L84.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nitpick

packages/web-app-text-editor/src/App.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🎨 nice!

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 355aa8f into master Jul 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the introduce-app-top-bar branch July 6, 2022 08:15
@micbar micbar mentioned this pull request Jul 19, 2022
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants