Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Shared with others page apps not working with oc10 as backend #7228

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Bugfix: Shared with others page apps not working with oc10 as backend #7228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b63fbf
Fix bug where mimetype doesn't get exposed
Jul 7, 2022
760a50d
Add changelog item
Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/bugfix-shared-with-others-page-apps-not-working-oc10
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Shared with others page apps not working with oc10 as backend

We've fixed a bug where apps like preview, pdf-viewer or text-editor weren't working while browsing
the shared with others page with oc10 as backend.

https://github.com/owncloud/web/pull/7228
https://github.com/owncloud/web/issues/7049
2 changes: 1 addition & 1 deletion packages/web-app-files/src/helpers/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ export function buildSharedResource(
fileId: share.item_source,
storageId: extractStorageId(share.item_source),
type: share.item_type,
mimeType: parseInt(share.state) === 0 ? share.mimetype : '',
mimeType: share.mimetype,
isFolder,
sdate: DateTime.fromSeconds(parseInt(share.stime)).toRFC2822(),
indicators: [],
Expand Down
3 changes: 0 additions & 3 deletions tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ Level-3 headings should be used for the references to the relevant issues. Inclu

Other free text and markdown formatting can be used elsewhere in the document if needed. But if you want to explain something about the issue, then please post that in the issue itself.

### [Preview from share-with-others page doesn't work in oc10](https://github.com/owncloud/web/issues/7049)
- [webUIPreview/mediaPreview.feature:143](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPreview/imageMediaViewer.feature#L143)

### [user session of a blocked user is not cleared properly](https://github.com/owncloud/web/issues/4795)
- [webUILogin/adminBlocksUser.feature:20](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/adminBlocksUser.feature#L20)

Expand Down