Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Updated expected to failure as the tests is passing on OCIS #7275

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 14, 2022

Description

This issue owncloud/ocis#3631 is passing on ocis. And is making fail to the ocis CI https://drone.owncloud.com/owncloud/ocis/13427/61/13. This PR removes the issue from expected to failure.

Part of:

owncloud/ocis#4197

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/26850/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L41.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L41.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@SwikritiT
Copy link
Contributor

SwikritiT commented Jul 14, 2022

I think you need to remove this from the expected to failure in OCIS repo as well, if it's passing on OCIS

https://github.com/owncloud/ocis/blob/3f80c8831d187b0b2bdf6baedf61c64b12b0be4b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md?plain=1#L334

But first make sure that it's an actual pass and not some false positive

@SagarGi
Copy link
Member Author

SagarGi commented Jul 14, 2022

I think you need to remove this from the expected to failure in OCIS repo as well, if it's passing on OCIS

https://github.com/owncloud/ocis/blob/3f80c8831d187b0b2bdf6baedf61c64b12b0be4b/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md?plain=1#L334

But first make sure that it's an actual pass and not some false positive

Oh my bad. I need to create it on ocis. This Pr can be used for Bumping COMMIT ID @SwikritiT

@SagarGi SagarGi force-pushed the updateExpectedToFailureForWebTestsonOcis branch from d9ceca3 to 1ae23fd Compare July 14, 2022 07:17
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was fixed in oCIS by oCIS PR owncloud/ocis#4132 but that PR was not run with full-ci, so it was not noticed that a web test scenario started passing.

@phil-davis phil-davis marked this pull request as ready for review July 14, 2022 07:48
@phil-davis phil-davis merged commit ec6bb7b into master Jul 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the updateExpectedToFailureForWebTestsonOcis branch July 14, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants