Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to spaces overview if space get's disabled #7334

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Redirect to spaces overview if space get's disabled #7334

merged 7 commits into from
Jul 26, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 26, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear requested a review from kulmann July 26, 2022 12:14
@update-docs
Copy link

update-docs bot commented Jul 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 26, 2022 12:18
lookacat
lookacat approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

kulmann
kulmann previously requested changes Jul 26, 2022
View reviewed changes
packages/web-app-files/src/views/spaces/Projects.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann July 26, 2022 15:10
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit c7bdd55 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7291 branch July 26, 2022 17:02
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need redirect to files/spaces/projects after disabling or deleting space
3 participants
@AlexAndBear @lookacat @kulmann