Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Remove mediaSource #7350

Merged
merged 8 commits into from
Jul 27, 2022
Merged

[full-ci] Remove mediaSource #7350

merged 8 commits into from
Jul 27, 2022

Conversation

dschmidt
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dschmidt dschmidt changed the title Remove media source Remove mediaSource Jul 27, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jul 27, 2022 •
edited
Loading

Results for oCISBasic https://drone.owncloud.com/owncloud/web/27080/52/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPreview-mediaPreview_feature-L25.png

webUIPreview-mediaPreview_feature-L25.png

@dschmidt dschmidt changed the title Remove mediaSource [full-ci] Remove mediaSource Jul 27, 2022
kulmann
kulmann approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dschmidt dschmidt force-pushed the remove_mediaSource branch 2 times, most recently from 0ee6f55 to 6689f86 Compare July 27, 2022 12:09
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

98.0% 98.0% Coverage
0.0% 0.0% Duplication

@dschmidt dschmidt merged commit 6d60038 into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove_mediaSource branch July 27, 2022 14:51
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of mediaSource
3 participants
@dschmidt @ownclouders @kulmann