Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview fixes #7359

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Preview fixes #7359

merged 3 commits into from
Jul 27, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jul 27, 2022 •
edited
Loading

Description

Fixes flickering in App Top Bar when browsing through files quickly. (as the top bar hasn't been released so far, I just added this PR to the according changelog item file)
Fixes infinite loading spinner on invalid filenames in url (e.g. when a bookmark is outdated)

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs

This comment was marked as resolved.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@kulmann kulmann merged commit 85c6bce into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the preview_fixes branch July 27, 2022 13:55
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @kulmann