Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Align drop menus #7365

Merged
merged 9 commits into from
Aug 1, 2022
Merged

[full-ci] Align drop menus #7365

merged 9 commits into from
Aug 1, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jul 28, 2022 •
edited
Loading

Description

We've styled and aligned all the drop menus in the right sidebar to match with the other drop menus. Additionally, we've removed the icon-highlight-box in the application menu and the left navigation.

Related Issue

Screenshots:

image

image

image

image

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 28, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jul 28, 2022 •
edited
Loading

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/27207/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L94.png

webUIUpload-upload_feature-L94.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 28, 2022

https://www.figma.com/file/EqAiB1wY7cYaMaitjyzup3/Current-oC-Web-UI-Kit-(WIP)?node-id=2224%3A225760

increase checkbox size to size L

@JammingBen JammingBen changed the title Align drop menus [fill-ci] Align drop menus Aug 1, 2022
@kulmann kulmann mentioned this pull request Aug 1, 2022
Merged
10 tasks
@JammingBen JammingBen changed the title [fill-ci] Align drop menus [full-ci] Align drop menus Aug 1, 2022
@JammingBen JammingBen marked this pull request as ready for review August 1, 2022 10:37
AlexAndBear
AlexAndBear approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@kulmann kulmann merged commit 8efecca into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the align-drop-menus branch August 1, 2022 14:16
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align all drop menus according to design
5 participants
@JammingBen @ownclouders @tbsbdr @kulmann @AlexAndBear