Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Use fixed width for the right sidebar #7371

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

We've set a fixed width of 440px to the right sidebar to have better control of its styling and alignment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 29, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jul 29, 2022

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/27177/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkPublicActions_feature-L82.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L82.png

@JammingBen JammingBen changed the title Use fixed width for the right sidebar [full-ci] Use fixed width for the right sidebar Jul 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review July 29, 2022 15:31
@AlexAndBear
Copy link
Contributor

@JammingBen As we don't have a ticket for this, I might ask if we need those changes for the user management as well?
could also make #6914 obsolete

@JammingBen
Copy link
Collaborator Author

@JammingBen As we don't have a ticket for this, I might ask if we need those changes for the user management as well?
could also make #6914 obsolete

I think it would make sense to apply it to the user management as well, yes. However, first we we'd need to adjust the mobile view of the table, just like in the files table (reduce columns for small screens to make space etc.). I'd rather do it in a separate PR.

@kulmann kulmann merged commit cb8f134 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the right-sidebar-fixed-with branch August 1, 2022 14:07
@micbar micbar mentioned this pull request Aug 11, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants