Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User management bottom bar state saved #7375

Merged
merged 11 commits into from
Aug 1, 2022
Merged

User management bottom bar state saved #7375

merged 11 commits into from
Aug 1, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 29, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 29, 2022 15:34
@AlexAndBear AlexAndBear changed the title Issues/7351 User management bottom bar state saved Jul 29, 2022
@AlexAndBear AlexAndBear marked this pull request as draft July 29, 2022 15:56
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Jul 29, 2022 •
edited
Loading

Bad: save state stays if user changes

RESOLVED

@AlexAndBear AlexAndBear marked this pull request as ready for review July 29, 2022 16:06
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement 💯

@kulmann kulmann merged commit a664eb7 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7351 branch August 1, 2022 08:22
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User management: Bottom bar should state "✅ Saved" on save (not "no changes" )
2 participants
@AlexAndBear @kulmann