Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltips are not shown on disabled buttons #7376

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Fix tooltips are not shown on disabled buttons #7376

merged 3 commits into from
Aug 1, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 30, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 30, 2022 11:49
@AlexAndBear AlexAndBear requested a review from kulmann July 30, 2022 11:51
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, I'm a bit surprised, that this is actually the way to go. My first thought was why don't we allow the tooltip directive / tippy.js to work on disabled buttons but then found e.g. this: atomiks/tippyjs#104 (comment)
Which is exactly what you did here. Good job! 💪

@kulmann kulmann merged commit 934a9e8 into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/5937 branch August 1, 2022 07:33
@micbar micbar mentioned this pull request Aug 11, 2022
26 tasks
@ishaiavrahami
Copy link

Hello, i noticed that its mentioned that's fixed in beta 6, however, i'm running beta 20 and its still not working. Any advice?

@kulmann
Copy link
Member

kulmann commented Dec 8, 2022

Hello, i noticed that its mentioned that's fixed in beta 6, however, i'm running beta 20 and its still not working. Any advice?

Hey, could you state the exact ocis version you're running? There is no ocis beta 20, we only had 2.0.0-beta.8 as last beta version, after that 2.0.0-rc.1, 2.0.0-rc.2 and the final 2.0.0 "general availability release".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix rendering of error in case of no quota space
3 participants