Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate tags #7442

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Truncate tags #7442

merged 3 commits into from
Aug 15, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 12, 2022 •
edited by fschade
Loading

Description

Add tag icon and text truncation.

Screenshots (if appropriate):

Clipboard - August 12, 2022 11_45 AM

@update-docs
Copy link

update-docs bot commented Aug 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from fschade August 12, 2022 09:48
@ownclouders
Copy link
Contributor

ownclouders commented Aug 12, 2022 •
edited
Loading

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/27524/46/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear
Copy link
Contributor Author

WHYYYYYYYYYYYYYYYYYY

fschade
fschade approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexAndBear AlexAndBear force-pushed the experimental-tags-truncate branch from e183d06 to e93f6a7 Compare August 15, 2022 13:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 007f880 into experimental Aug 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the experimental-tags-truncate branch August 15, 2022 14:26
@phil-davis
Copy link
Contributor

WHYYYYYYYYYYYYYYYYYY

@janackermann can you share what was the problem/fix with the XGAportrait test pipelines? It might be helpful for others to be aware of whatever are the design/layout/screen-rendering tricks to be aware of.

@fschade
Copy link
Contributor

fschade commented Aug 15, 2022

@phil-davis , we've added one additional column tags in the files table, this way the total table width was larger than the available viewport width.... and selenium wasnt able to find open sidebar CTA and boom...

fschade added a commit that referenced this pull request Aug 16, 2022
@fschade @lookacat
[full-ci] Merge master into experimental (#7460)
83bc21c 
* change ocis to experimental
change sdk to experimental

* bump ocis commit id

* Add tags to ResourceTable (#7388)

* Add tags to resourcetable

* Use file tags instead of tags

* Add changelog, remove border for + item

* Replace OcFileTag

* Dump ODS

* [full-ci] Tags (#7385)

Tags init

* Truncate tags (#7442)

Truncate tags

Co-authored-by: Paul Neubauer <paulneubauer@live.de>
Co-authored-by: Jan <jackermann@owncloud.com>
JammingBen pushed a commit that referenced this pull request Dec 5, 2022
@JammingBen
Truncate tags (#7442)
6fcb471 
Truncate tags
JammingBen pushed a commit that referenced this pull request Dec 8, 2022
@JammingBen
Truncate tags (#7442)
2a0230f 
Truncate tags
JammingBen pushed a commit that referenced this pull request Dec 9, 2022
@JammingBen
Truncate tags (#7442)
3a64fdd 
Truncate tags
fschade pushed a commit that referenced this pull request Dec 20, 2022
@fschade
Truncate tags (#7442)
ee75bde 
Truncate tags
fschade pushed a commit that referenced this pull request Dec 21, 2022
@fschade
Truncate tags (#7442)
4bdf3b6 
Truncate tags
fschade pushed a commit that referenced this pull request Dec 22, 2022
@fschade
Truncate tags (#7442)
87f50cc 
Truncate tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @phil-davis @fschade