Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar loading for the current folder #7527

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

JammingBen
Copy link
Collaborator

Description

We've fixed a bug where the right sidebar for the current folder could not be opened when another resource was selected.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 25, 2022
@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/27825/39/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L94.png

webUIUpload-upload_feature-L94.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly a (right) click on any file row is supposed to set the selection on its own already. I don't understand why we now need to set the file selection in the trigger methods. Did you investigate that?

@JammingBen
Copy link
Collaborator Author

If I remember correctly a (right) click on any file row is supposed to set the selection on its own already.

That's right, but a click on a file row is not happening, as the current folder sidebar gets opened via the breadcrumb menu.

@kulmann
Copy link
Member

kulmann commented Aug 25, 2022

If I remember correctly a (right) click on any file row is supposed to set the selection on its own already.

That's right, but a click on a file row is not happening, as the current folder sidebar gets opened via the breadcrumb menu.

Ah right, sorry, now I get it. Could've just read more carefully 👀

@JammingBen JammingBen merged commit 9d6e30b into master Aug 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the sidebar-current-folder branch August 25, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar for the current folder does not work when resources are selected
3 participants