[full-ci] Space root not updated #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/28757/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28757/tracing/public-link-for-space-alice-2022-9-29-11-41-02.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/28757/tracing/public-link-for-space-brian-2022-9-29-11-41-31.zip |
|
No changelog item needed |
kulmann
requested changes
Aug 31, 2022
|
Not so good - postponed |
JammingBen
force-pushed
the
issues/7521
branch
from
6b9be05
to
ea8b650
Compare
JammingBen
reviewed
Sep 21, 2022
| return | ||
| } | ||
|
|
||
| this.loading = true | ||
| // shared resources look different, hence we need to fetch the actual resource here |
There was a problem hiding this comment.
I always wondered why we have highlightedFile AND selectedFile. Turns out, it's needed because share resources look different than "normal" resources. Some information like mdate is missing in a built share. Therefore we need to fetch the actual resource in such cases.
Maybe the OCS share API will be extended by the missing properties in the future. Then we could skip this whole fetching-stuff here.
JammingBen
force-pushed
the
issues/7521
branch
from
6b3ede0
to
5c69f5a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: