Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed share filtering code #7645

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 16, 2022

Description

Remove share filtering, due to owncloud/ocis#3592 is fixed

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear requested a review from kulmann September 16, 2022 01:49
@update-docs
Copy link

update-docs bot commented Sep 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Remove not needed code Remove not needed share filtering code Sep 16, 2022
@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/28372/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L106.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L106.png

💥 The oC10SharingPublic1 tests pipeline failed. The build has been cancelled.

@AlexAndBear
Copy link
Contributor Author

Oh c'mon

@phil-davis
Copy link
Contributor

Oh c'mon

https://drone.owncloud.com/owncloud/web/28372/37/20
Error: Scenario webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:106 failed but was not expected to fail.'

The test is trying to choose an expiration date +15 days in the future. That is 1 Oct 2022. I suspect that there is some problem with the test code accessing the first day of the next month, or... Navigating the date-picker in tests is painful - there are lots of possibilities depending on which day of the week each month starts on, and how the "5" weeks of a month get displayed...

I have asked for someone to have a look.

@amrita-shrestha
Copy link
Contributor

@SwikritiT will be looking in this

@SwikritiT
Copy link
Contributor

the issue here is this #7513, the test tries to select +15 which is next month oct, and when the test attempts to select the month oct the scroller scrolls up and the test cannot select the month.

simplescreenrecorder-2022-09-16_12.15.40.mp4

I'll add a commit skipping the test to unblock this PR

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT
Copy link
Contributor

The ci is green

@phil-davis phil-davis merged commit 7188e9f into master Sep 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-shared-with-others-filter branch September 16, 2022 07:22
@AlexAndBear
Copy link
Contributor Author

Thx 👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants