-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not needed share filtering code #7645
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/28372/37/1 💥 The oC10SharingPublic1 tests pipeline failed. The build has been cancelled. |
Oh c'mon |
https://drone.owncloud.com/owncloud/web/28372/37/20 The test is trying to choose an expiration date +15 days in the future. That is 1 Oct 2022. I suspect that there is some problem with the test code accessing the first day of the next month, or... Navigating the date-picker in tests is painful - there are lots of possibilities depending on which day of the week each month starts on, and how the "5" weeks of a month get displayed... I have asked for someone to have a look. |
@SwikritiT will be looking in this |
the issue here is this #7513, the test tries to select simplescreenrecorder-2022-09-16_12.15.40.mp4I'll add a commit skipping the test to unblock this PR |
Kudos, SonarCloud Quality Gate passed! |
The ci is green |
Thx 👍👍👍 |
Description
Remove share filtering, due to owncloud/ocis#3592 is fixed
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: