UI improvements #7966
Merged
UI improvements #7966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
approved these changes
Dec 2, 2022
(when sharing with user and/or multiple groups)
…tead of hoverable
diocas
force-pushed
the
up_ui_improvements
branch
from
66a3ed6
to
e3309b6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug: if
hoverableQuickActions: true, the context menus disappear if the mouse exits them or the table row area....and improves the sorting in the shared with view.
In the current behaviour it only sorts by the first sharee name, which means we might have rows with multiple sharees (user + groups) appearing in the middle of other rows that only have the user in the sharees.
This was particularly visible and bad because we even allow multiple groups to appear in this list (as opposed to ocis which seems to be showing only the first group?).
(like in all PRs, I can add the changelog if you think this is ok to be merged)