-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement zoom and rotate for preview app #7977
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/29905/37/1 💥 The oC10SharingPublic2 tests pipeline failed. The build has been cancelled. |
I really don't know what to "unit-test" here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controls for zoom feel a bit jumpy, depending on the percentage value shown in the controls. Could you make this a fixed width somehow?
Other than that only a nitpick about some code deduplication. Feature itself works like a charm, I love it!
I was a bit irritated that the zoom and rotate controls only appear after the image is loaded (that looks funny when browsing through a folder of only images, because the zoom and rotate controls disappear and then reappear all the time). But that will be somewhat fixed when we introduce preloading of images. So nothing we need to worry about here.
Thx for the feedback! |
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it 😍
Description
Related Issue
zoom
androtate
options #7160Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: