Implement full screen mode #7994
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/29971/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29971/tracing/file-alice-2022-11-18-09-07-42.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29971/tracing/file-brian-2022-11-18-09-08-05.zip |
There was a problem hiding this comment.
I don't know if full screen is the correct term for this... might be that the wording needs to be adjusted.
One thing that confused me when flipping though images fast, was, that the loading screen lacks the lightbox styles. i.e. you get thrown out of the (now called) full screen mode for the loading state, and then back into the full screen mode when the image has been loaded. That needs fixing, the lightbox should stay there at all times until the user goes back.
One more thing for making this great: the ESC key should only clear the full screen mode, but as of now it triggers the closeApp action instead. Could you look into that?
AlexAndBear
force-pushed
the
issues/6700
branch
from
ff1faa5 to
2320db9
Compare
|
SonarCloud Quality Gate failed. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: