Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable autoplay #7995

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Enable autoplay #7995

merged 3 commits into from
Nov 28, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 18, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Nov 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review November 18, 2022 09:10
@dschmidt
Copy link
Member

Hrm, I guess this means always autoplay?
I think I expect autoplay when I open the file by clicking on it, but probably not when just advancing to the next file

@kulmann
Copy link
Member

kulmann commented Nov 18, 2022

Hrm, I guess this means always autoplay?
I think I expect autoplay when I open the file by clicking on it, but probably not when just advancing to the next file

I had the same thought: #7908 (comment)

@AlexAndBear
Copy link
Contributor Author

Hm, if I switch between music or videos in vlc there is autoplay activated.

I like it tough, but I don't decide that 😜

@dschmidt
Copy link
Member

Hm, if I switch between music or videos in vlc there is autoplay activated.

I like it tough, but I don't decide that stuck_out_tongue_winking_eye

Yeah, agreed, but I would argue: switching from pictures to videos is different. When I browse through pictures it might be surprising when I reach the end of the folder with videos and there's suddenly loud sound from the speakers

@AlexAndBear
Copy link
Contributor Author

Enable autoplay button ;) ?

@dschmidt
Copy link
Member

Where? How permanent is the setting? Where is it stored?

@AlexAndBear
Copy link
Contributor Author

discussed with @dschmidt -> autoplay only on app start

kulmann
kulmann approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@dschmidt
Copy link
Member

Needs rebase :trollface:

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 53c2470 into master Nov 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7908 branch November 28, 2022 14:01
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt dschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable autoplay on media files
3 participants
@AlexAndBear @dschmidt @kulmann