[tests-only] Add unit tests for the text editor #8002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
SonarCloud fails because of 0.0% condition coverage... makes sense 🤡 |
dschmidt
approved these changes
Nov 20, 2022
JammingBen
force-pushed
the
add-text-editor-unit-tests
branch
from
98cc316 to
6f7cb99
Compare
dschmidt
approved these changes
Nov 24, 2022
| const defaultMocks = { ...defaultComponentMocks() } | ||
| const storeOptions = { ...defaultStoreMockOptions } | ||
| const localVue = defaultLocalVue() | ||
| const store = createStore(Vuex.Store, storeOptions) |
There was a problem hiding this comment.
Out of scope for this PR, but:
I don't like that you use options from test helpers but have to add vuex-extensions to the package dependencies, I would like to see this handled in web-test-helpers completely.
We should really throw some time at unit tests at some point, unify the setup and clean up stuff like this.
kulmann
suggested changes
Nov 24, 2022
| import { GetFileContentsResponse } from 'web-client/src/webdav/getFileContents' | ||
| import { AppConfigObject, FileContext, useAppDefaults } from 'web-pkg/src' | ||
|
|
||
| export const useAppDefaultsMock = ( |
There was a problem hiding this comment.
Still amazed by the mocks with the partial type for options 😎
JammingBen
force-pushed
the
add-text-editor-unit-tests
branch
from
30817cc to
5c52f8d
Compare
|
SonarCloud Quality Gate failed. |
kulmann
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a mock for the
useAppDefaultscomposable.Types of changes